Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

9684: No ACL set for integrations #12332

Merged
merged 1 commit into from
Nov 18, 2017
Merged

9684: No ACL set for integrations #12332

merged 1 commit into from
Nov 18, 2017

Conversation

RomaKis
Copy link
Contributor

@RomaKis RomaKis commented Nov 17, 2017 •
edited
Loading

Fixed Issues (if relevant)

  1. No ACL set for integrations #9684: No ACL set for integrations

Manual testing scenarios

  1. Create admin role.
  2. Set custom role resources.
  3. Select all resources.
  4. Add a user to the role.
  5. Login as this user.
  6. Search for 'System > Extentions > Integrations.

Expected result:
Extentions > Integrations is present on the System tab.
Actual result:
Extentions > Integrations is absent on the System tab

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team magento-engcom-team added Admin Panel bugfix Component: Customer Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Nov 17, 2017
@dmanners dmanners self-assigned this Nov 17, 2017
@dmanners dmanners added this to the November 2017 milestone Nov 17, 2017
@dmanners dmanners self-requested a review November 17, 2017 14:23
@magento-team magento-team merged commit ffb7817 into magento:2.2-develop Nov 18, 2017
magento-team pushed a commit that referenced this pull request Nov 18, 2017
@ishakhsuvarov
MAGETWO-84081: 9684: No ACL set for integrations #12332
e03892c
magento-team pushed a commit that referenced this pull request Nov 18, 2017
@ishakhsuvarov
Merge pull request #1734 from magento-engcom/2.2-develop-prs
b05a957 
[EngCom] Public Pull Requests - 2.2-develop
 - MAGETWO-84098: Webshop throws an exception when sharing wishlist with RSS enabled #12276
 - MAGETWO-84081: 9684: No ACL set for integrations #12332
 - MAGETWO-84006: Fix robots.txt content type to 'text/plain' #12310
 - MAGETWO-83977: Handle empty or incorrect lines in a language CSV #12304
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmanners dmanners dmanners approved these changes

Assignees

@dmanners dmanners

Labels
bugfix Component: Customer Progress: accept Release Line: 2.2 Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Milestone
November 2017
Development

Successfully merging this pull request may close these issues.
4 participants
@RomaKis @dmanners @magento-team @magento-engcom-team